Improves the white screen at startup #6168
Conversation
…tup white window when the graphics drive is initialization (only windows)
|
|
britzl
added
the
ok to test
|
Fixes #5419 |
| // Change from the default white background to black to improve the startup white window when the graphics drive is initialization | ||
| wc.hbrBackground = (HBRUSH)GetStockObject(BLACK_BRUSH); |
There was a problem hiding this comment.
Thanks for this. I agree it's an improvement.
Some questions/discussions though:
Q: Is black universally "better"?
Q: I would also have liked us to use the chosen background color from the game.
From the linked issue: "what would be best is if we had some control over what is displayed at this point "
There was a problem hiding this comment.
Adding @britzl to the discussion.
There was a problem hiding this comment.
Yeah, we'd like to use the graphics.clear_color from game.project, but for now maybe accept this PR and then fix it properly later?
There was a problem hiding this comment.
I'm investigating the proper solution now.
There was a problem hiding this comment.
Best practices should be when adaptive game starts with splash background color (if splash background color is customizable).
Because this is when the window for reinitialization windows occurs (when the window class is register), the game engine should not have been initialized correctly at this time, and it takes some trick to read the preset values of the engine.
So if you're not sure, black is a more professional and common background color in most games.
There was a problem hiding this comment.
An @britzl says, the graphics.clear_color is color we want here, and we want to figure out a good way to propagate it down to the window initialization. At that stage, we have read the project config settings, and have access to the color, so now it's a matter of figuring out how to pass it down to those places that need it.
|
This PR doesn't solve the issue with what seems like one window opening and quickly closing before the real window opens. |
|
Changes and additional work moved to PR: #6185 |
Change from the default white background to black to improve the startup white window when the graphics drive is initialization (only windows)