Skip to content
This repository was archived by the owner on Jul 23, 2021. It is now read-only.

Conversation

@traviskeenan
Copy link
Contributor

We had a use-case to download a different extension type. This pull request adds the ability to specify an optional argument of extensions while defaulting to the current default of 'integrations' if no argument is given.

@codecov-io
Copy link

codecov-io commented Jul 18, 2018

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #96   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         357    371   +14     
  Branches       41     42    +1     
=====================================
+ Hits          357    371   +14
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️
src/downloadDocumentation.spec.js 100% <100%> (ø) ⬆️
src/downloadDocumentation.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3edff8...7b561f2. Read the comment docs.

@traviskeenan
Copy link
Contributor Author

Looks that this may address the following open issue:
#90

Copy link
Collaborator

@aaleksandrov aaleksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aaleksandrov
Copy link
Collaborator

@tchock Please review and merge

@tchock tchock merged commit e0c8e35 into deliveryhero:master Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants