Fix of Random failing tests refs #91

[Ayybeeshafi]

I figured out that failing of test is not random. Whichever testcase succeeded DashboardOverviewComponent should create failed.
We are using RouterModule in this testcase. I presume that this component couldn't be removed before next test or something like that.
My solution for this problem was calling
fixture.destroy() in afterEach in spec of DashboardOverviewComponent.
Tests are executing fine on the build pipeline as well as my machine.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (develop@08fdb6e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             develop    #100   +/-   ##
=========================================
  Coverage           ?   4.69%           
=========================================
  Files              ?      11           
  Lines              ?     213           
  Branches           ?      15           
=========================================
  Hits               ?      10           
  Misses             ?     203           
  Partials           ?       0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fdb6e...a4aea52. Read the comment docs.

[janniclas]

hey @Ayybeeshafi ,
thanks for the research it's good to know there is at least some "consistency" in the failing tests.
About the dashboard-overview component and its tests. I'm a little bit confused here why we test with the angular router here in the first place. If I'm not mistaken the router-outlet is only explicitly used in the dashboard component.
Now I wonder if we actually might need the Angular RouterTesting module only in the dashboard component or also in every component where we do some routing? But anyways I believe it should definitely be added to the dashboard component where we actually use the router-outlet, do you agree?
Could you please have a look at these questions? :)