HUBS-1695 | Add example documentation for database specific VDB provi… #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uddipaan-Hazarika
requested review from
arunskurian,
elima-sugunan,
eyalkaspi-delphix,
kishlay-delphix,
nick-mathison and
sunnyx4
nick-mathison
requested changes
May 16, 2023
Contributor
nick-mathison
left a comment
nick-mathison
left a comment
There was a problem hiding this comment.
Please add this folder too: https://github.com/nick-mathison/delphix-terraform-examples/tree/main/simple-provision
nick-mathison
requested changes
May 16, 2023
elima-sugunan
requested changes
May 16, 2023
Contributor
elima-sugunan
left a comment
elima-sugunan
left a comment
There was a problem hiding this comment.
@Uddipaan-Hazarika Are the passwords used in multiple files, a commonly used one for Delphix. If so, we need to replace that with a sample one.
nick-mathison
approved these changes
May 16, 2023
elima-sugunan
approved these changes
May 17, 2023
elima-sugunan
approved these changes
May 17, 2023
elima-sugunan
approved these changes
May 17, 2023
arunskurian
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Add example documentation for database specific VDB provision parameters.
Problem: It was hard to figure out the parameters needed to provision a specific database with a huge list of parameters available to us.
Solution: We provided some set of known databases with terraform files that can be used to provision their respective VDBs.
Testing: These MD files can be tested visually in a terraform supported doc preview tool