Skip to content

Conversation

@nick-mathison
Copy link
Contributor

Cleaned up the main page.

Points of Note:

  • Clarified the description
  • Added System Requirements section that broadly states support across the provider.
  • Updated the organization of the example script. Mad reference the other documentation.

docs/index.md Outdated
key = "dct_api_key"
host = "dct_hostname"
key = "dct_api_key"
tls_insecure_skip = true
Copy link
Contributor

@ankit-patil-hubs ankit-patil-hubs Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting true means we bypass the SSL, i think we should remove this because by default it is set to false which keeps SSL enabled

Copy link
Contributor

@ankit-patil-hubs ankit-patil-hubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good , just one comment

docs/index.md Outdated

!> **NOTE**
The Terraform Provider for Delphix requires the Delphix Continuous Data Platform and Data Control Tower (DCT).
The Terraform Provider for Delphix enables customers to natively manage data-as-code along with their infrastructure.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace customers with you and their with your
The Terraform Provider for Delphix enables you to natively manage data-as-code along with your infrastructure.

docs/index.md Outdated
!> **NOTE**
The Terraform Provider for Delphix requires the Delphix Continuous Data Platform and Data Control Tower (DCT).
The Terraform Provider for Delphix enables customers to natively manage data-as-code along with their infrastructure.
With Terraform and Delphix, customers can now automatically provision, manage, and teardown any number of ephemeral data environments to drive enterprise DevOps workflows, such as test data management.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace customers with you

docs/index.md Outdated
## Argument Reference
* __host__: The hostname for DCT.
* __key__ : The API Key which is used to authenticate with DCT. (Example `apk 2.abc123...`).
* __tls_insecure_skip__: (Optional) A boolean value which determines whether to skip the SSL/TLS check. The dfault value is `false`. Skipping any SSL/TLS check is not recommended for production environments.
Copy link

@manishagupta0303 manishagupta0303 Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default spelling is wrong in "The dfault value is `false'.

@Uddipaan-Hazarika
Copy link
Contributor

@ankit-patil-hubs Please check if we are directly pushing to main branch rather than going through develop. This way we may get commit mismatches between branches main and develop.

@ankit-patil-hubs
Copy link
Contributor

ankit-patil-hubs commented Mar 11, 2024

we usually follow first to dev and then dev-> main , @nick-mathison can we change the branch from main to dev in this PR

@nick-mathison
Copy link
Contributor Author

sure. I'll do it tomorrow

@nick-mathison
Copy link
Contributor Author

Creating pull request on develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants