Skip to content

Conversation

@ankit-patil-hubs
Copy link
Contributor

@ankit-patil-hubs ankit-patil-hubs commented Mar 28, 2024

Problem:

As per the discussion with customer, they have noticed intermittently that storage_size keeps changing even tough the dsource is disabled and this causes their TF plan to fail,when we tried to reproduce locally we don't see an issue as storage_size is a computed field , but customers are using github actions where between the TF plan and TF apply stage if any attribute changes the next steps fail .

They tried adding storage_size to the ignore_changes = [storage_size] block which is a feature provided by Terraform to ignore variables in a particular lifecycle but it only works on non-computed attributes , we have defined storage_size as computed so this does not solve the problem for them.

Solution:

As storage_size is not important for infra as code, at this point, this looks like a good solution to remove this attribute and later reintroduce it if required .

Testing

dsoruce in 3.1.0 -> storage_size is available

image

upgrade to 3.2.2 -> storage_size removed post plan and apply

image

Manually Tested

Copy link
Contributor

@Uddipaan-Hazarika Uddipaan-Hazarika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ankit-patil-hubs ankit-patil-hubs merged commit bb67fed into develop Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants