ESCL-4870 : Terraform dsource provider doesn't support ignore_changes in the lifecycle block #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
As per the discussion with customer, they have noticed intermittently that
storage_sizekeeps changing even tough the dsource is disabled and this causes their TF plan to fail,when we tried to reproduce locally we don't see an issue asstorage_sizeis a computed field , but customers are using github actions where between the TF plan and TF apply stage if any attribute changes the next steps fail .They tried adding
storage_sizeto theignore_changes = [storage_size]block which is a feature provided by Terraform to ignore variables in a particular lifecycle but it only works on non-computed attributes , we have definedstorage_sizeas computed so this does not solve the problem for them.Solution:
As
storage_sizeis not important for infra as code, at this point, this looks like a good solution to remove this attribute and later reintroduce it if required .Testing
dsoruce in 3.1.0 ->
storage_sizeis availableupgrade to 3.2.2 ->
storage_sizeremoved post plan and applyManually Tested