Fixed for login screen enhancements #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilkumar-delphix
approved these changes
Nov 30, 2022
|
|
||
| var authSuccess = function(data) { | ||
| var api_key_input = document.getElementsByTagName('input')[0]; | ||
| var api_key_input = document.querySelector('input[name="value"]'); |
There was a problem hiding this comment.
Can you please upgrade the version and update the version information in README.md file? So that 6.0.16 can use the current version and 6.0.17+ will use your changes.
You can take a reference from https://github.com/delphix/Delphix-Masking-API-Client-Extension/pull/3/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login Screen Changes after Swagger UI usability fixes done under https://delphix.atlassian.net/browse/DLPX-83733
Problem:
The Query selector for API Key input was written in a generic way. It was picking the username filed in the new implementation. As a result, API Key was submitted as the username on the new screen.
Solution:
Added the required qualifier to pick the exact input box.
Testing