Skip to content

Conversation

@sumedhbala-delphix
Copy link
Contributor

@sumedhbala-delphix sumedhbala-delphix commented Aug 19, 2022

Need to build delphix maintained fio which runs on python3. This adds delphix/fio to linux-pkg
Testing:
ab-pre-push: http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/2924/ (upgrade hit a known bug)
Verified this change adds the fio build job to jenkins: http://selfservice.jenkins-sbala.dcol2.delphix.com/job/linux-pkg/job/master/job/build-package/job/fio/

Copy link
Contributor

@prakashsurya prakashsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. IIRC, we need to land this in a few sequential steps, if we want to avoid build failures..

  1. land config.sh changes ..
  2. build package via Jenkins job
  3. land main.pkgs changes..

so we'll need separate PRs for (1) and (3).. otherwise, we'll get build failures due to (3) landing before (2) is completed (and we can't do (2), until (1) is landed)..

or we just land this as-is, and ignore any build failures that may occur until the package is built.. I'm fine either way..

@sumedhbala-delphix sumedhbala-delphix force-pushed the dlpx/pr/sumedhbala-delphix/a48cdc0f-3d4c-483b-bfbb-2503a7b6a6b6 branch from 27d8b59 to e406085 Compare August 22, 2022 16:52
@sumedhbala-delphix
Copy link
Contributor Author

LGTM.. IIRC, we need to land this in a few sequential steps, if we want to avoid build failures..

  1. land config.sh changes ..
  2. build package via Jenkins job
  3. land main.pkgs changes..

so we'll need separate PRs for (1) and (3).. otherwise, we'll get build failures due to (3) landing before (2) is completed (and we can't do (2), until (1) is landed)..

or we just land this as-is, and ignore any build failures that may occur until the package is built.. I'm fine either way..

I can monitor the build and rebuild after the first failure.

@sumedhbala-delphix sumedhbala-delphix force-pushed the dlpx/pr/sumedhbala-delphix/a48cdc0f-3d4c-483b-bfbb-2503a7b6a6b6 branch from e406085 to 8f1219b Compare August 22, 2022 18:42
@sumedhbala-delphix sumedhbala-delphix marked this pull request as ready for review August 22, 2022 18:56
@sumedhbala-delphix sumedhbala-delphix merged commit 3df3b33 into 6.0/stage Aug 23, 2022
@sumedhbala-delphix sumedhbala-delphix deleted the dlpx/pr/sumedhbala-delphix/a48cdc0f-3d4c-483b-bfbb-2503a7b6a6b6 branch August 23, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants