GHM-822 Build virtalization package with secrets #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinner-m-c
force-pushed
the
ms/GHM-822
branch
from
4e523ad to
ed7ca5a
Compare
Contributor
prakashsurya
left a comment
prakashsurya
left a comment
There was a problem hiding this comment.
LGTM.. just some relatively minor comments/questions..
prakashsurya
approved these changes
Oct 12, 2022
skinner-m-c
force-pushed
the
ms/GHM-822
branch
from
ed7ca5a to
febb867
Compare
prakashsurya
approved these changes
Oct 13, 2022
sebroy
approved these changes
Oct 14, 2022
skinner-m-c
pushed a commit
to skinner-m-c/linux-pkg
that referenced
this pull request
Oct 14, 2022
This reverts commit e55022a.
prakashsurya
pushed a commit
that referenced
this pull request
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes jumpbox information the virtualization build.
Discussions about this work might want to take offline due to the nature of this work and this being a public repo.