Skip to content

Invalid mem errors when using latest BCC #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Invalid mem errors when using latest BCC #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions bpf/estat/backend-io.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,16 @@
#define READ_STR "read "
#define WRITE_STR "write "
#define OP_NAME_LEN 7
#define DEV_NAME_LEN 8
#define NAME_LENGTH (OP_NAME_LEN + 1)
#define AXIS_LENGTH (DEV_NAME_LEN + 1)
#define AXIS_LENGTH (DISK_NAME_LEN + 1)

// Structure to hold thread local data
typedef struct {
u64 ts;
unsigned int size;
unsigned int cmd_flags;
u32 err;
char device[DEV_NAME_LEN];
char device[DISK_NAME_LEN];
} io_data_t;

BPF_HASH(io_base_data, u64, io_data_t);
Expand All @@ -40,7 +39,7 @@ disk_io_start(struct pt_regs *ctx, struct request *reqp)
data.ts = bpf_ktime_get_ns();
data.cmd_flags = reqp->cmd_flags;
data.size = reqp->__data_len;
__builtin_memcpy(&data.device, diskp->disk_name, DEV_NAME_LEN);
bpf_probe_read_str(&data.device, DISK_NAME_LEN, diskp->disk_name);
io_base_data.update((u64 *) &reqp, &data);
return (0);
}
Expand Down
2 changes: 1 addition & 1 deletion bpf/stbtrace/io.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ int disk_io_start(struct pt_regs *ctx, struct request *reqp)
data.ts = bpf_ktime_get_ns();
data.cmd_flags = reqp->cmd_flags;
data.size = reqp->__data_len;
__builtin_memcpy(&data.device, diskp->disk_name, DISK_NAME_LEN);
bpf_probe_read_str(&data.device, DISK_NAME_LEN, diskp->disk_name);
io_base_data.update((u64 *) &reqp, &data);
return 0;
}
Expand Down