Skip to content

Conversation

@wakamex
Copy link
Contributor

@wakamex wakamex commented Feb 7, 2025

I still get insufficient allowance
Screenshot_20250206-210224.png

@vercel
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 4:09pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 4:09pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 4:09pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 4:09pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 4:09pm
testnet-v1 ⬜️ Ignored (Inspect) Feb 7, 2025 4:09pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 4:09pm
trading-competition ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 4:09pm

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 349ab3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MazyGio
Copy link
Contributor

MazyGio commented Feb 7, 2025

Changed short padding back to 1%, but also fixed how it was being calculated. Previously, although we wanted to increase the allowance by 1% (i.e. multiply by 1.01e18), what we were actually doing was a much smaller increase (i.e., multiplying by 1e18 + 1), which often resulted in 0.

@MazyGio MazyGio merged commit e7aed8d into main Feb 7, 2025
15 checks passed
@MazyGio MazyGio deleted the wakamex/increase_short_padding branch February 7, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants