Read hyperdrive SDK updates for zaps #1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a68de25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
jackburrus
commented
Feb 7, 2025
|
|
||
| export const publicClient: PublicClient = createPublicClient({ | ||
| transport: http(process.env.RPC_URL), | ||
| chain: { |
Contributor
Author
There was a problem hiding this comment.
Looks like the update to viem now requires an explicit chain.
DannyDelott
approved these changes
Feb 7, 2025
| /** | ||
| * The optional address of an auxiliary contract such as a zap contract. | ||
| */ | ||
| readonly auxiliaryContractAddress?: Address; |
Contributor
There was a problem hiding this comment.
Minor: Since this is only used for zapping logic, let's just call this zapContractAddress so it's more clear for now.
| }); | ||
|
|
||
| const longsReceived = transfersReceived.filter((event) => { | ||
| const isLongEvent = ( |
Contributor
There was a problem hiding this comment.
Can this be broken out to a function in module scope?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SDK to keep track of close long positions handled by the zap contract.