Skip to content

Adds zap contract address to getHyperdrive #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2025
Merged

Adds zap contract address to getHyperdrive #1778

merged 3 commits into from
Feb 10, 2025

Conversation

@jackburrus
Copy link
Contributor

@jackburrus jackburrus commented Feb 10, 2025 •
edited
Loading

This PR adds the zapContractAddress param to each instance of getHyperdrive.

jackburrus and others added 2 commits February 10, 2025 11:17
@jackburrus @DannyDelott
adds zap contract to getHyperdrive
9c5b7c9 
Co-authored-by: Danny Delott <DannyDelott@users.noreply.github.com>
@jackburrus
cleanup console logs
e8d937c
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b98ecb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 7:21pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 7:21pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 7:21pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Feb 10, 2025 7:21pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Feb 10, 2025 7:21pm
testnet-v1 ⬜️ Ignored (Inspect) Feb 10, 2025 7:21pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 7:21pm
trading-competition ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 7:21pm

DannyDelott
DannyDelott approved these changes Feb 10, 2025
View reviewed changes
packages/hyperdrive-js/src/hyperdrive/ReadHyperdrive.ts Outdated
const accountTxHashes = transfersSentToZap.map(
({ transactionHash }) => transactionHash,
);
// Fetch CloseLong events emitted by the auxiliary contract in the relevant block range.
Copy link
Contributor

@DannyDelott DannyDelott Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: auxiliary contract -> zap contract

apps/hyperdrive-trading/src/ui/portfolio/lp/usePortfolioLpData.ts Outdated
drift: getDrift({ chainId: hyperdrive.chainId }),
earliestBlock: hyperdrive.initializationBlock,
zapContractAddress:
appConfigForConnectedChain.zaps[hyperdrive.chainId].address,
Copy link
Contributor

@DannyDelott DannyDelott Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since zaps is only configured for the fork chain, we need to do ?.address everywhere, right?

@jackburrus jackburrus merged commit 2f415fc into main Feb 10, 2025
13 of 15 checks passed
@jackburrus jackburrus deleted the adds-zap-address branch February 10, 2025 19:19
@DannyDelott DannyDelott mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DannyDelott DannyDelott DannyDelott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackburrus @DannyDelott