-
Notifications
You must be signed in to change notification settings - Fork 4
Light-mode polish #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light-mode polish #426
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fd541e1 to
477f435
Compare
| }, | ||
| ); | ||
| const className = classNames("daisy-card p-4 bg-base-200 border border-1", { | ||
| "shadow-[rgba(50,_50,_105,_0.15)_0px_2px_5px_0px,_rgba(0,_0,_0,_0.05)_0px_1px_1px_0px]": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the default tailwind shadows here, ie shadow-md. I notice there's the slighest bit more bleed than with the custom but it still looks good. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep good call, I was playing around with some examples from https://manuarora.in/boxshadows, but shadow-md is almost identical to this like you said.
477f435 to
57ac400
Compare
| if (token.symbol) { | ||
| return <span className="daisy-label-text">{token.symbol}</span>; | ||
| } | ||
| })()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My max button isn't showing for shorts. Same for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional. We don't show one for shorts.
|
I think if we are going B&W across the board, we should remove the purple buttons and labels on the position table. It feels out of place. Same with the red on short action buttons. |
Yep, will tackle that in the next PR since I'll be refactoring the tables, those buttons are going away in fact! |
elevationprop to Well component