Skip to content

Conversation

@DannyDelott
Copy link
Contributor

  • Open/Closed tabs are now standard daisy unboxed tabs
  • Added elevation prop to Well component
  • Stripped off any button colors in modals, table rows

image

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-fixed-borrow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 10:03pm
hyperdrive-monorepo-hyperdrive-trading ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 10:03pm
hyperdrive-sdk-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 10:03pm

},
);
const className = classNames("daisy-card p-4 bg-base-200 border border-1", {
"shadow-[rgba(50,_50,_105,_0.15)_0px_2px_5px_0px,_rgba(0,_0,_0,_0.05)_0px_1px_1px_0px]":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the default tailwind shadows here, ie shadow-md. I notice there's the slighest bit more bleed than with the custom but it still looks good. wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep good call, I was playing around with some examples from https://manuarora.in/boxshadows, but shadow-md is almost identical to this like you said.

if (token.symbol) {
return <span className="daisy-label-text">{token.symbol}</span>;
}
})()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My max button isn't showing for shorts. Same for you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. We don't show one for shorts.

@jackburrus
Copy link
Contributor

I think if we are going B&W across the board, we should remove the purple buttons and labels on the position table. It feels out of place. Same with the red on short action buttons.

@DannyDelott
Copy link
Contributor Author

I think if we are going B&W across the board, we should remove the purple buttons and labels on the position table. It feels out of place. Same with the red on short action buttons.

Yep, will tackle that in the next PR since I'll be refactoring the tables, those buttons are going away in fact!

@DannyDelott DannyDelott merged commit 04fe127 into main Oct 12, 2023
@DannyDelott DannyDelott deleted the danny-lightmode-polish branch October 12, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants