Adds filtering and sorting #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DannyDelott
approved these changes
Oct 13, 2023
Comment on lines
112
to
128
| <div className="flex gap-2"> | ||
| {["All", "Long", "Short"].map((filter) => ( | ||
| <button | ||
| key={filter} | ||
| className={`${ | ||
| header.column.getFilterValue() !== filter | ||
| ? "text-base-300/30" | ||
| : "" | ||
| }`} | ||
| onClick={() => | ||
| header.column.setFilterValue(filter) | ||
| } | ||
| > | ||
| {filter} | ||
| </button> | ||
| ))} | ||
| </div> |
There was a problem hiding this comment.
nit: Let's use daisy-tabs https://daisyui.com/components/tab/#tabs
Comment on lines
95
to
100
| {...{ | ||
| className: header.column.getCanSort() | ||
| ? "cursor-pointer select-none flex gap-2 items-center" | ||
| : "", | ||
| onClick: header.column.getToggleSortingHandler(), | ||
| }} |
There was a problem hiding this comment.
minor nit: no need for the object spread
<div
className={classNames({
"cursor-pointer select-none flex gap-2 items-center": header.column.getCanSort(),
})}
onClick={header.column.getToggleSortingHandler()}>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds filtering and sorting to the transactions table
Screen.Recording.2023-10-12.at.6.38.18.PM.mov