Skip to content

Update columns in Longs table #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 13, 2023
Merged

Update columns in Longs table #430

merged 9 commits into from
Oct 13, 2023

Conversation

@DannyDelott
Copy link
Contributor

@DannyDelott DannyDelott commented Oct 13, 2023 •
edited
Loading

image

@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-fixed-borrow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 10:57pm
hyperdrive-monorepo-hyperdrive-trading ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 10:57pm
hyperdrive-sdk-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 10:57pm

@DannyDelott DannyDelott force-pushed the danny-longs-table branch 2 times, most recently from 3a7ac35 to 45e2731 Compare October 13, 2023 07:42
jackburrus
jackburrus reviewed Oct 13, 2023
View reviewed changes
apps/hyperdrive-trading/src/ui/portfolio/OpenLongsTable/OpenLongsTable.tsx Outdated
rows={openLongRows}
showSkeleton={openLongRowsStatus === "loading"}
/>
<div className="flex items-center gap-1">
Copy link
Contributor

@jackburrus jackburrus Oct 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responsiveness issues here on smaller screens. Probably just needs a flex-col breakpoint to place the badge underneath.
Screenshot 2023-10-13 at 4 11 57 PM

@DannyDelott DannyDelott merged commit feb8ea8 into main Oct 13, 2023
@DannyDelott DannyDelott deleted the danny-longs-table branch October 13, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jackburrus jackburrus jackburrus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DannyDelott @jackburrus