Skip to content

Fix sluggishness when clicking CTAs #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Fix sluggishness when clicking CTAs #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cf186f
remove routing from cards
DannyDelott Oct 16, 2023
c9b1a0b
Add vercel.json so routing works in vercel
DannyDelott Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions apps/hyperdrive-trading/src/ui/hyperdrive/longs/OpenLongModalButton/OpenLongModalButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { ChevronRightIcon, ClockIcon } from "@heroicons/react/24/outline";
import { ReactElement } from "react";
import { useSearchParams } from "react-router-dom";
import { Hyperdrive } from "src/appconfig/types";
import { ChecklistItem } from "src/ui/base/components/ChecklistItem/ChecklistItem";
import { Modal } from "src/ui/base/components/Modal/Modal";
Expand All @@ -16,7 +15,6 @@ export function OpenLongModalButton({
hyperdrive: Hyperdrive;
}): ReactElement {
const { fixedAPR } = useCurrentFixedAPR(hyperdrive);
const [searchParams, setSearchParams] = useSearchParams();
return (
<Modal
modalId={OPEN_LONG_MODAL_ID}
Expand All @@ -26,11 +24,6 @@ export function OpenLongModalButton({
<Well
interactive
onClick={() => {
setSearchParams({
...searchParams,
position: "Buys",
openOrClosed: "Open",
});
showModal();
}}
>
Expand Down
7 changes: 0 additions & 7 deletions ...perdrive-trading/src/ui/hyperdrive/lp/AddLiquidityModalButton/AddLiquidityModalButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { ChevronRightIcon, SquaresPlusIcon } from "@heroicons/react/24/outline";
import { ReactElement } from "react";
import { useSearchParams } from "react-router-dom";
import { Hyperdrive } from "src/appconfig/types";
import { ChecklistItem } from "src/ui/base/components/ChecklistItem/ChecklistItem";
import { Modal } from "src/ui/base/components/Modal/Modal";
Expand All @@ -14,7 +13,6 @@ export function AddLiquidityModalButton({
}: {
hyperdrive: Hyperdrive;
}): ReactElement {
const [searchParams, setSearchParams] = useSearchParams();
return (
<Modal
modalId={ADD_LIQUIDITY_MODAL_ID}
Expand All @@ -24,11 +22,6 @@ export function AddLiquidityModalButton({
<Well
interactive
onClick={() => {
setSearchParams({
...searchParams,
position: "LP",
openOrClosed: "Open",
});
return showModal();
}}
>
Expand Down
7 changes: 0 additions & 7 deletions ...hyperdrive-trading/src/ui/hyperdrive/shorts/OpenShortModalButton/OpenShortModalButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { BoltIcon, ChevronRightIcon } from "@heroicons/react/24/outline";
import { ReactElement } from "react";
import { useSearchParams } from "react-router-dom";
import { Hyperdrive } from "src/appconfig/types";
import { ChecklistItem } from "src/ui/base/components/ChecklistItem/ChecklistItem";
import { Modal } from "src/ui/base/components/Modal/Modal";
Expand All @@ -14,7 +13,6 @@ export function OpenShortModalButton({
}: {
hyperdrive: Hyperdrive;
}): ReactElement {
const [searchParams, setSearchParams] = useSearchParams();
const { vaultRate } = useVaultRate({
// TODO: temporary for now until this available via addresses.json
vaultAddress: "0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512",
Expand All @@ -28,11 +26,6 @@ export function OpenShortModalButton({
<Well
interactive
onClick={() => {
setSearchParams({
...searchParams,
position: "Shorts",
openOrClosed: "Open",
});
return showModal();
}}
>
Expand Down
3 changes: 3 additions & 0 deletions apps/hyperdrive-trading/vercel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"rewrites": [{ "source": "/(.*)", "destination": "/" }]
}