Refactor markets table #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackburrus
commented
Oct 17, 2023
| baseAmountOut && | ||
| formatBalance({ | ||
| balance: row.original.bondAmount - baseAmountOut, | ||
| balance: baseAmountOut, |
There was a problem hiding this comment.
Fixed the value here like we talked about on the implied yield call yesterday.
DannyDelott
approved these changes
Oct 17, 2023
| const ALL_TERM_LENGTHS_KEY = 0; | ||
| const columnHelper = createColumnHelper<MarketTableRowData>(); | ||
|
|
||
| function columns() { |
There was a problem hiding this comment.
nit: Is it idiomatic react-table to call this function just columns? Feels we should be calling this getColumns(), but willing to do whatever the common practice is here.
Agreed. I'll change this over in the other tables as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the markets table to use React Table and refactors some other pieces of the code.