Skip to content

Pluralize #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Pluralize #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27d0769
Pluralize
DannyDelott Oct 18, 2023
fcb293c
pluralize transaction tabs
DannyDelott Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/hyperdrive-trading/src/ui/hyperdrive/TransactionTable/TransactionsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ const getColumns = (hyperdrive: Hyperdrive) => [
if (filterValue === "All") {
return true;
}
if (filterValue === "Long") {
if (filterValue === "Longs") {
return ["Open Long", "Close Long"].includes(type);
}
if (filterValue === "Short") {
if (filterValue === "Shorts") {
return ["Open Short", "Close Short"].includes(type);
}
if (filterValue === "LP") {
Expand Down Expand Up @@ -131,7 +131,7 @@ export function TransactionTable({
</div>
{header.column.getCanFilter() ? (
<div className="daisy-tabs-lg">
{["All", "Long", "Short", "LP"].map((filter) => (
{["All", "Longs", "Shorts", "LP"].map((filter) => (
<a
key={filter}
className={`${
Expand Down
2 changes: 1 addition & 1 deletion apps/hyperdrive-trading/src/ui/portfolio/PositionTabs/PositionTabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export function PositionTabs({
},
)}
>
Long
Longs
</button>
<button
onClick={() => onTabClick("Shorts")}
Expand Down