Refactor open lp table #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DannyDelott
approved these changes
Oct 18, 2023
| })} | ||
| </tbody> | ||
| </table> | ||
| {!lpShares || !withdrawalShares ? <NonIdealState /> : null} |
There was a problem hiding this comment.
I think this should be &&, no? If they're both missing then show non ideal state?
| const lpShares = getValue(); | ||
| return ( | ||
| <span key="type" className="font-semibold uppercase"> | ||
| {lpShares ? "LP" : "Pending withdrawal"} |
There was a problem hiding this comment.
Change this from "Pending withdrawal" to "Withdrawal shares" to also knock out one of the items under LP in the feedback checklist #446 😎
| <span> | ||
| {formatBalance({ | ||
| balance: row.original.withdrawalShares || 0n, | ||
| decimals: hyperdrive.baseToken.decimals, |
There was a problem hiding this comment.
Let's take this to 4 places as well and check off another item under LP in #446
| id: "value", | ||
| header: "Value", | ||
| cell: ({ row }) => { | ||
| return <ValueCell key="value_1" hyperdrive={hyperdrive} row={row} />; |
There was a problem hiding this comment.
ah forgot to remove it here. Key is moved to id, so react table knows how to differentiate rows. Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors openlp table to use react-table:
