Skip to content

Conversation

@jalextowle
Copy link
Contributor

When thinking about supporting various types of integrations and considering the gas cost of adding events, it seemed best to add events to the core functions. This will make it trivial to pull down realized price information, information about open trader positions, and changes in LP positions.

@github-actions
Copy link

github-actions bot commented May 23, 2023

Hyperdrive Gas Benchmark

Benchmark suite Current: 4f036d2 Previous: 69d4a19 Deviation Status
addLiquidity: min 711 gas 711 gas 0% 🟰
addLiquidity: avg 44884 gas 44668 gas 0.4836% 🚨
addLiquidity: max 82408 gas 81028 gas 1.7031% 🚨
checkpoint: min 492 gas 492 gas 0% 🟰
checkpoint: avg 23044 gas 23044 gas 0% 🟰
checkpoint: max 33513 gas 33513 gas 0% 🟰
closeLong: min 637 gas 637 gas 0% 🟰
closeLong: avg 45705 gas 43798 gas 4.3541% 🚨
closeLong: max 80843 gas 79240 gas 2.0230% 🚨
closeShort: min 616 gas 616 gas 0% 🟰
closeShort: avg 37136 gas 35545 gas 4.4760% 🚨
closeShort: max 80392 gas 78750 gas 2.0851% 🚨
initialize: min 667 gas 667 gas 0% 🟰
initialize: avg 139799 gas 138216 gas 1.1453% 🚨
initialize: max 141296 gas 139696 gas 1.1453% 🚨
openLong: min 685 gas 685 gas 0% 🟰
openLong: avg 107671 gas 105277 gas 2.2740% 🚨
openLong: max 149220 gas 147584 gas 1.1085% 🚨
openShort: min 727 gas 727 gas 0% 🟰
openShort: avg 142803 gas 142042 gas 0.5358% 🚨
openShort: max 208468 gas 206459 gas 0.9731% 🚨
removeLiquidity: min 547 gas 547 gas 0% 🟰
removeLiquidity: avg 58828 gas 60944 gas -3.4720%
removeLiquidity: max 113193 gas 111079 gas 1.9032% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle force-pushed the jalextowle/hyperdrive/events branch from ee986eb to fd5ec72 Compare May 23, 2023 05:33
@coveralls
Copy link
Collaborator

coveralls commented May 23, 2023

Coverage Status

Coverage: 81.877% (+0.4%) from 81.491% when pulling 4f036d2 on jalextowle/hyperdrive/events into 69d4a19 on main.

Copy link
Contributor

@aleph-v aleph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jalextowle jalextowle merged commit 036d7bd into main May 23, 2023
@jalextowle jalextowle deleted the jalextowle/hyperdrive/events branch May 23, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants