Skip to content

Conversation

@jalextowle
Copy link
Contributor

This PR adds a Deployed event to the HyperdriveFactory. It also sets the linker factory and code hash in the factory, which is better for security reasons.

@github-actions
Copy link

Hyperdrive Gas Benchmark

Benchmark suite Current: fb2d8ee Previous: 7233c4d Deviation Status
addLiquidity: min 687 gas 687 gas 0% 🟰
addLiquidity: avg 48151 gas 48583 gas -0.8892%
addLiquidity: max 83594 gas 83594 gas 0% 🟰
checkpoint: min 514 gas 514 gas 0% 🟰
checkpoint: avg 23022 gas 23022 gas 0% 🟰
checkpoint: max 33418 gas 33418 gas 0% 🟰
closeLong: min 659 gas 659 gas 0% 🟰
closeLong: avg 45882 gas 45909 gas -0.0588%
closeLong: max 80429 gas 81328 gas -1.1054%
closeShort: min 616 gas 616 gas 0% 🟰
closeShort: avg 41016 gas 40925 gas 0.2224% 🚨
closeShort: max 81627 gas 81627 gas 0% 🟰
initialize: min 687 gas 687 gas 0% 🟰
initialize: avg 139461 gas 139461 gas 0% 🟰
initialize: max 140690 gas 140690 gas 0% 🟰
openLong: min 661 gas 661 gas 0% 🟰
openLong: avg 106492 gas 107216 gas -0.6753%
openLong: max 148643 gas 148643 gas 0% 🟰
openShort: min 687 gas 687 gas 0% 🟰
openShort: avg 138640 gas 137719 gas 0.6688% 🚨
openShort: max 207767 gas 207767 gas 0% 🟰
removeLiquidity: min 547 gas 547 gas 0% 🟰
removeLiquidity: avg 61001 gas 60449 gas 0.9132% 🚨
removeLiquidity: max 116344 gas 116344 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.471% (+2.2%) from 92.317% when pulling fb2d8ee on jalextowle/factories/events into 7233c4d on main.

Copy link
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jalextowle jalextowle merged commit 8a560f4 into main Jun 14, 2023
@jalextowle jalextowle deleted the jalextowle/factories/events branch June 14, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants