Skip to content

Conversation

@shmuel44
Copy link
Contributor

@shmuel44 shmuel44 commented Oct 16, 2025

Related Issues

fixes: link to the issue

Description

  • Resolved an issue where commands would fail if the Incident Severity parameter was not set. The solution involved adding a default value of "All" to this parameter.

The problem occurred on line 452, where the code checked if "All" was contained in the severity variable. Since severity was None at that time, it resulted in a TypeError: TypeError: argument of type 'NoneType' is not iterable.

To fix this, I added a default value of "All" to the Incident Severity parameter, aligning it with the existing default value for the Incident Type parameter.

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/GuardiCore/Integrations/GuardiCoreV2
   GuardiCoreV2.py2928271%93, 171–179, 181–182, 189–192, 194, 196, 204, 209–212, 216–219, 230, 232, 309–310, 325, 337, 367, 373–374, 407, 409, 441–448, 451–466, 468–474, 486–495, 497, 500–501
TOTAL2928271% 

Tests Skipped Failures Errors Time
30 0 💤 0 ❌ 0 🔥 2.450s ⏱️

@shmuel44 shmuel44 changed the title GuardiCoreV2 GuardiCoreV2 : Enhancement of Incident Severity Parameter to Prevent Command Failures Oct 16, 2025
@shmuel44 shmuel44 added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Oct 16, 2025
@shmuel44 shmuel44 self-assigned this Oct 19, 2025
Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
@talihaff
Copy link
Contributor

@shmuel44 docs approved

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@shmuel44 shmuel44 merged commit 9a5f811 into master Oct 21, 2025
19 checks passed
@shmuel44 shmuel44 deleted the sk_Guardicorev2_fix_none branch October 21, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants