-
Notifications
You must be signed in to change notification settings - Fork 1.9k
GuardiCoreV2 : Enhancement of Incident Severity Parameter to Prevent Command Failures #41572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
||||||||||||||||||||||||||||||
BEAdi
reviewed
Oct 19, 2025
BEAdi
approved these changes
Oct 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
talihaff
reviewed
Oct 20, 2025
|
@shmuel44 docs approved |
Co-authored-by: talihaff <thaffner@paloaltonetworks.com>
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs-approved
ready-for-pipeline-running
Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: link to the issue
Description
The problem occurred on line 452, where the code checked if "All" was contained in the
severityvariable. Sinceseveritywas None at that time, it resulted in a TypeError:TypeError: argument of type 'NoneType' is not iterable.To fix this, I added a default value of "All" to the Incident Severity parameter, aligning it with the existing default value for the Incident Type parameter.