Small improvement to Sbom tool execution #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR makes small improvements to the SBOM (Software Bill of Materials) tool execution by cleaning up argument formatting and correcting parameter values. The changes aim to resolve potential build issues on push by using proper string representations and more appropriate parameter values.
Key changes:
- Replace manual string quoting with ToString() method calls for path arguments
- Update build config root to use RootDirectory instead of current directory
- Change package supplier from RepositoryOwner to ProductName
| "-b", ArtifactsDirectory.ToString(), // Base path for the build output | ||
| "-bc", RootDirectory.ToString(), // Project root | ||
| "-m", SbomDirectory.ToString(), // Output SBOM manifest dir | ||
| "-pn", ProjectName, // Package name" |
There was a problem hiding this comment.
There's an extra closing quote in the comment. The comment should end with 'Package name' not 'Package name"'.
Suggested change
| "-pn", ProjectName, // Package name" | |
| "-pn", ProjectName, // Package name |
eNeRGy164
added
the
workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fixes build on push