[update-docs] Add further documentation #150
Conversation
ebebbington
changed the title
docs/README.md
Outdated
| This improves performance, as creating a whole new connection for each query can be an expensive operation. | ||
| With pools, you can keep the connections open to be re-used when requested (`const client = dbPool.connect()`). So one of the active connections will be used instead of creating a new one. | ||
|
|
||
| The number of pools is up to you, but 50 is generally a good number, but this can differ based on how active your application is. |
There was a problem hiding this comment.
where did you see 50 as being a good number? I thought I had seen 20 be recommended (somewhere)... 😄
Overall this seems good change 👍
There was a problem hiding this comment.
Can't remember now 😕 Like you, i saw it somewhere 😄 I'll change it to 20 though 👍
There was a problem hiding this comment.
Changed it here: 1d62518, note when i say "I think ...", i refer to yourself
There was a problem hiding this comment.
ha! I just looked at a few of my applications and see 200 - so maybe I was confused (though I've no idea how well deno handles that many open). I'd probably say "many" applications (or even "most") rather than "small".
Will merge anyway. One thing I like to use sometimes is to have multiple query pools - that way longer-running queries can be put into a separate pool (and not slow down queries which are important to be fast).
2 participants
Fixes #145
Fixes #147
Adds documentation on the returned type for a query. This fixes issues for people who use
deno lint(it throws a lot of errors when executing onresultorclient)