fix: type reconnectTimer as setTimeout return value#3820
Merged
Conversation
The runtime type of setTimeout's return value changed to a Timeout object, so the explicit `number` annotation no longer type-checks. Using `ReturnType<typeof setTimeout>` keeps the declaration accurate across runtimes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev HMR client declares
reconnectTimerasnumber, but the runtimetype of
setTimeout's return value is aTimeoutobject, sodeno checknow fails with
TS2322: Type 'Timeout' is not assignable to type 'number'at
packages/fresh/src/runtime/client/dev_hmr.ts:32. This is blockingevery PR's type check job. Switching the annotation to
ReturnType<typeof setTimeout>keeps the declaration accurate withoutcommitting to a specific runtime's timer type.