Skip to content

Conversation

@neilmartin83
Copy link
Contributor

Change

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

New function and example script for getting /v1/oidc/direct-idp-login-url - new endpoint in 11.19

Type of Change

Please DELETE options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)
  • Refactor (refactoring code, removing code, changing code structure)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@neilmartin83 neilmartin83 requested a review from ShocOne as a code owner July 31, 2025 15:45
@thejoeker12
Copy link
Contributor

Same here as the blank push comment - could the arg patterns be simplified?

@neilmartin83
Copy link
Contributor Author

Do you mean for the ResponseOIDCDirectIdPLoginURL struct? Just return a string instead? There's no request struct involved in this one.

@ShocOne
Copy link
Member

ShocOne commented Aug 11, 2025

@thejoeker12 , the structs appear to be unique responses for seperate endpoints. So im happy with this

@ShocOne ShocOne merged commit f3a6277 into deploymenttheory:main Aug 12, 2025
2 of 4 checks passed
Copy link
Member

@ShocOne ShocOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@neilmartin83 neilmartin83 deleted the nm-oidc-11-19 branch November 25, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants