local_archive strategy: race condition on shared archive.tar when deploying to multiple hosts in parallel

[rockschtar]

Deployer Version

v8.0.5

Target OS

Rocky Linux 9.7

Which PHP version are you using?

PHP 8.4

Content of deploy.php or deploy.yaml

import:
  - recipe/common.php

config:
  update_code_strategy: local_archive

hosts:
  host-a:
    hostname: example.com
    remote_user: deployer
    deploy_path: /var/www/site-a
    labels: { env: production }
  host-b:
    hostname: example.com
    remote_user: deployer
    deploy_path: /var/www/site-b
    labels: { env: production }

tasks:
  deploy:
    - deploy:prepare
    - deploy:symlink
    - deploy:unlock
    - deploy:cleanup
    - deploy:success

Steps to reproduce

1. Configure two (or more) hosts and set update_code_strategy: local_archive (see config above).
2. Run a deploy that selects both hosts, without --limit:
   dep deploy env=production --revision=<sha>
3. Deployer runs deploy:update_code on both hosts in parallel (default behavior).

Expected: both hosts deploy successfully.

Actual: the host that finishes first deletes the shared local archive.tar; the slower host then fails:

[host-a] 1/1 [≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡] 100% < 1 ms/< 1 ms
[host-b] 1/1 [≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡≡] 100% < 1 ms/< 1 ms
[host-a]  ErrorException  in update_code.php on line 88:
[host-a]
[host-a]   unlink(/builds/my-project/archive.tar): No such file or directory

The whole deploy then aborts via deploy:failed.

Root cause: in recipe/deploy/update_code.php (v8.0.5), the local_archive branch uses a single shared file
$gitRoot/archive.tar for all hosts:

if ($strategy === 'local_archive') {
    $gitRoot = runLocally("git rev-parse --show-toplevel");
    runLocally("git -C " . quote($gitRoot) . " archive $targetWithDir -o archive.tar");
    upload("$gitRoot/archive.tar", '{{release_path}}/archive.tar');
    run("tar -xf {{release_path}}/archive.tar -C {{release_path}}");
    run("rm {{release_path}}/archive.tar");
    unlink("$gitRoot/archive.tar");

Every host process creates, uploads and finally unlink()s the same local file. Besides the unlink() failure shown above, there are worse latentcraces: host B may re-run git archive (rewriting the file) or delete it while host A is still mid-upload(), which could silently upload a truncatedcarchive.

Workaround: deploy serially with dep deploy ... --limit 1 (or task('deploy:update_code')->limit(1)).

Suggested fix: use a per-host archive filename (e.g. archive-{{alias}}.tar), or build the archive once before the host fan-out and clean it up after all hosts have finished.