Consolidate duplicate output helpers into output.go

Extract validateOutputFormat and isJSONOutput into output.go to eliminate
code duplication between summary.go and metrics.go. This follows the
existing pattern of shared output logic and ensures consistent validation
across CI verbs.

Author: cursoragent

pkg/cmd/ci/metrics.go

@@ -38,7 +38,7 @@ func NewCmdMetrics() *cobra.Command {
   depot ci metrics --job job_123 --output json
   depot ci metrics --run run_123 --output json`,
 		RunE: func(cmd *cobra.Command, args []string) error {
-			if err := validateMetricsOutput(output); err != nil {
+			if err := validateOutputFormat(output); err != nil {
 				return err
 			}
 			if len(args) > 1 {
@@ -84,7 +84,7 @@ func NewCmdMetrics() *cobra.Command {
 					}
 					return fmt.Errorf("failed to get job metrics: %w", err)
 				}
-				if metricsOutputJSON(output) {
+				if isJSONOutput(output) {
 					return writeJSON(buildJobMetricsJSON(resp))
 				}
 				printJobMetrics(resp, orgFlag)
@@ -96,7 +96,7 @@ func NewCmdMetrics() *cobra.Command {
 					}
 					return fmt.Errorf("failed to get run metrics: %w", err)
 				}
-				if metricsOutputJSON(output) {
+				if isJSONOutput(output) {
 					return writeJSON(buildRunMetricsJSON(resp))
 				}
 				printRunMetrics(resp, orgFlag)
@@ -108,7 +108,7 @@ func NewCmdMetrics() *cobra.Command {
 					}
 					return fmt.Errorf("failed to get attempt metrics: %w", err)
 				}
-				if metricsOutputJSON(output) {
+				if isJSONOutput(output) {
 					return writeJSON(buildAttemptMetricsJSON(resp))
 				}
 				printAttemptMetrics(resp, orgFlag)
@@ -451,17 +451,6 @@ func connectErrorText(err error) string {
 	return ""
 }
 
-func validateMetricsOutput(output string) error {
-	if output == "" || output == "text" || output == "json" {
-		return nil
-	}
-	return fmt.Errorf("unsupported output %q (valid: text, json)", output)
-}
-
-func metricsOutputJSON(output string) bool {
-	return output == "json"
-}
-
 func countNonEmpty(values ...string) int {
 	count := 0
 	for _, value := range values {

pkg/cmd/ci/output.go

@@ -2,6 +2,7 @@ package ci
 
 import (
 	"encoding/json"
+	"fmt"
 	"os"
 )
 
@@ -12,3 +13,17 @@ func writeJSON(v any) error {
 	enc.SetIndent("", "  ")
 	return enc.Encode(v)
 }
+
+// validateOutputFormat validates that the output format is one of: "", "text", or "json".
+// Used by CI verbs that support --output flags.
+func validateOutputFormat(output string) error {
+	if output == "" || output == "text" || output == "json" {
+		return nil
+	}
+	return fmt.Errorf("unsupported output %q (valid: text, json)", output)
+}
+
+// isJSONOutput returns true if the output format is "json".
+func isJSONOutput(output string) bool {
+	return output == "json"
+}

pkg/cmd/ci/summary.go

@@ -33,7 +33,7 @@ func NewCmdSummary() *cobra.Command {
   depot ci summary <job-id>
   depot ci summary <attempt-id> --output json`,
 		RunE: func(cmd *cobra.Command, args []string) error {
-			if err := validateSummaryOutput(output); err != nil {
+			if err := validateOutputFormat(output); err != nil {
 				return err
 			}
 			if len(args) == 0 {
@@ -60,7 +60,7 @@ func NewCmdSummary() *cobra.Command {
 
 			resp, attemptErr := ciGetJobAttemptSummary(ctx, tokenVal, orgID, id)
 			if attemptErr == nil {
-				if summaryOutputJSON(output) {
+				if isJSONOutput(output) {
 					return writeJSON(buildSummaryJSON(resp))
 				}
 				return printSummaryResponse(cmd.OutOrStdout(), resp)
@@ -82,7 +82,7 @@ func NewCmdSummary() *cobra.Command {
 				return fmt.Errorf("failed to get job summary: %w", jobErr)
 			}
 
-			if summaryOutputJSON(output) {
+			if isJSONOutput(output) {
 				return writeJSON(buildSummaryJSON(resp))
 			}
 
@@ -156,14 +156,3 @@ func emptySummaryMessage(resp *civ1.GetJobSummaryResponse) string {
 		return "No CI step summary was produced."
 	}
 }
-
-func validateSummaryOutput(output string) error {
-	if output == "" || output == "text" || output == "json" {
-		return nil
-	}
-	return fmt.Errorf("unsupported output %q (valid: text, json)", output)
-}
-
-func summaryOutputJSON(output string) bool {
-	return output == "json"
-}