Skip to content

Commit 948dfe9

Browse files
committed
Fix sandbox stream completion handling
1 parent e800208 commit 948dfe9

2 files changed

Lines changed: 1 addition & 8 deletions

File tree

pkg/api/rpc.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,6 @@ func NewSandboxV0Client() sandboxv1connect.SandboxServiceClient {
6464
return sandboxv1connect.NewSandboxServiceClient(getHTTPClient(getBaseURL()), getBaseURL(), WithUserAgent())
6565
}
6666

67-
// NewSandboxSpecV0Client returns a connect client for the depot.sandbox.v1
68-
// SandboxSpecService. The single RPC CreateSandboxFromSpec is the server-side
69-
// orchestrator backing `depot sandbox from-spec` (the M34 rename of `up`).
70-
func NewSandboxSpecV0Client() sandboxv1connect.SandboxSpecServiceClient {
71-
return sandboxv1connect.NewSandboxSpecServiceClient(getHTTPClient(getBaseURL()), getBaseURL(), WithUserAgent())
72-
}
73-
7467
func NewRegistryClient() buildv1connect.RegistryServiceClient {
7568
return buildv1connect.NewRegistryServiceClient(getHTTPClient(getBaseURL()), getBaseURL(), WithUserAgent())
7669
}

pkg/cmd/sandbox/common.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,5 +99,5 @@ func consumeCommandEventStream(
9999
if err := stream.Err(); err != nil && !errors.Is(err, io.EOF) {
100100
return 0, fmt.Errorf("command stream: %w", err)
101101
}
102-
return 0, nil
102+
return 0, fmt.Errorf("command stream ended without Finished event")
103103
}

0 commit comments

Comments
 (0)