-
Notifications
You must be signed in to change notification settings - Fork 19
fix: loading and firebase feature flag #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amam-deriv
merged 1 commit into
deriv-com:master
from
mayuran-deriv:mayuran/fix-feature-flag-firebase-and-initial-loading
May 27, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import { useState, useEffect } from 'react'; | ||
import { getTmbConfigUrl } from '@site/src/utils'; | ||
|
||
/** | ||
* Hook to fetch and determine if TMB (Third-party Marketplace Business) is enabled | ||
* @returns {[boolean, boolean]} A tuple containing [isTmbEnabled, isLoading] | ||
*/ | ||
const useTmbEnabled = (): [boolean, boolean] => { | ||
const [isTmbEnabled, setIsTmbEnabled] = useState(false); | ||
const [isLoading, setIsLoading] = useState(true); | ||
|
||
// Get the TMB config URL from utils | ||
const configUrl = getTmbConfigUrl(); | ||
|
||
// Fetch TMB enabled status from remote config | ||
useEffect(() => { | ||
if (!configUrl) return; | ||
|
||
const fetchTmbStatus = async () => { | ||
setIsLoading(true); | ||
try { | ||
const response = await fetch(configUrl); | ||
const data = await response.json(); | ||
|
||
// Use the "api" key from the response, default to false if undefined | ||
const isEnabled = data?.api === true; | ||
|
||
// Store the value in localStorage for other components to use | ||
if (typeof window !== 'undefined') { | ||
localStorage.setItem('is_tmb_enabled', JSON.stringify(!!isEnabled)); | ||
} | ||
|
||
setIsTmbEnabled(!!isEnabled); | ||
} catch (error) { | ||
console.error('Failed to fetch TMB status:', error); | ||
setIsTmbEnabled(false); | ||
} finally { | ||
setIsLoading(false); | ||
} | ||
}; | ||
|
||
fetchTmbStatus(); | ||
}, [configUrl]); | ||
|
||
return [isTmbEnabled, isLoading]; | ||
}; | ||
|
||
export default useTmbEnabled; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was thinking to have localstorage to override as a backdoor
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localstorage will override value from firebase as a backdoor, by default localstorage will be empty, once it is set, it will override, if its empty, read from firebase