Skip to content

Fix Perl::Critic issues #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2018
Merged

Fix Perl::Critic issues #20

merged 5 commits into from
Oct 31, 2018

Conversation

@zakame
Copy link
Contributor

@zakame zakame commented Oct 31, 2018

  • Remove List::MoreUtils and replace with simpler equivalents (pairwise, indexes)
  • Do not use $a and $b outside sort()

zakame added 4 commits October 31, 2018 11:51
@zakame
Quadratic.pm: Fix tiny perlcritic issue
d98449c 
Do not use the `$a` and `$b` variables which are used for `sort()`.
@zakame
Cubic.pm: Simplify pairwise() in _spline_points()
e1b2222 
We just need to map() points between `$Xs` and `@y2_derivative` (which
already have a 1:1 correspondence), so no need for the List::MoreUtils
function.
@zakame
Interpolator.pm: Simplify finding indexes for closest_three_points()
e74b87a 
List::MoreUtils::indexes() isn't really needed here.
@zakame
cpanfile: Remove List::MoreUtils
26210c9 
No need for this dist anymore.
@codecov-io
Copy link

codecov-io commented Oct 31, 2018 •
edited
Loading

Codecov Report

Merging #20 into master will increase coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   93.95%   94.55%   +0.59%     
==========================================
  Files           4        4              
  Lines         149      147       -2     
  Branches       22       22              
==========================================
- Hits          140      139       -1     
+ Misses          1        0       -1     
  Partials        8        8
Impacted Files Coverage Δ
lib/Math/Function/Interpolator/Cubic.pm 98.24% <ø> (+1.69%) ⬆️
lib/Math/Function/Interpolator.pm 92.15% <100%> (-0.16%) ⬇️
lib/Math/Function/Interpolator/Quadratic.pm 89.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e40efb6...242d27b. Read the comment docs.

@zakame
v1.03
242d27b 
        - Remove List::MoreUtils and replace with simpler equivalents (pairwise, indexes)
        - Do not use `$a` and `$b` outside `sort()`
@raunakkathuria raunakkathuria merged commit 0bcb813 into deriv-com:master Oct 31, 2018
@zakame zakame deleted the zakame/fix_perlcritic_issues branch October 31, 2018 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zakame @codecov-io @raunakkathuria