Fix NPE when deleting nonexistent entity.

[SimY4]

No description provided.

[codecov-io]

Codecov Report

Merging #175 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #175      +/-   ##
============================================
- Coverage     63.65%   63.61%   -0.04%     
  Complexity      562      562              
============================================
  Files            72       72              
  Lines          1978     1979       +1     
  Branches        374      375       +1     
============================================
  Hits           1259     1259              
- Misses          574      575       +1     
  Partials        145      145

Impacted Files	Coverage Δ	Complexity Δ
...namodb/repository/query/AbstractDynamoDBQuery.java	19.49% <0%> (-0.17%)	7 <0> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d3b58...7e73403. Read the comment docs.

[derjust]

Thanks for your PR!

I just tested with the provided test case (big thanks!) but got the expected EmptyResultDataAccessException do you encounter a NullPointerException?
Which version of spring-data-dynamodb do you use?

[SimY4]

Hi, @derjust

So, provided by default in CrudRepository#deleteById(ID) will throw EmptyResultDataAccessException.

But if you create a custom delete method like MyRepo#deleteBySomethingEquals(String) if no entity satisfies given condition, Null pointer exception is raised.

[SimY4]

Another observation: the delete executor in current form will always delete single record even if query params will return more than one. Should I change query.getSingleResult() to query,getResultList() and then run bulk delete if result list is not empty?