Skip to content

Conversation

@suryavikas
Copy link

There was a bug where when DynamoDBMapperConfig when passed from Spring config XML file was never picked up due to a typo.

config
<bean id="amazonDynamoDB" class="com.amazonaws.services.dynamodbv2.AmazonDynamoDBClient">
	<constructor-arg ref="amazonAWSCredentials" />		
	<property name="endpoint" value="${amazon.dynamodb.endpoint}" />
</bean>


<dynamodb:repositories
	base-package="nz.co.mightyriverpower.consumptiondata.dynamodb.repository"
	amazon-dynamodb-ref="amazonDynamoDB"  **dynamodb-mapper-config-ref**="dynamoDBMapperConfig" dynamodb-operations-ref=""/>

This bug fix will allow user to prefix or change dynamo db table names, using XML configuration instead of switching to Java code.

@codecov-io
Copy link

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #85   +/-   ##
=========================================
  Coverage     40.58%   40.58%           
  Complexity      336      336           
=========================================
  Files            64       64           
  Lines          1752     1752           
  Branches        341      341           
=========================================
  Hits            711      711           
  Misses          936      936           
  Partials        105      105
Impacted Files Coverage Δ Complexity Δ
...tory/config/DynamoDBRepositoryConfigExtension.java 0% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deef49a...b8bd30f. Read the comment docs.

@derjust
Copy link
Owner

derjust commented Oct 3, 2017

Thank you!

@derjust derjust merged commit 909c785 into derjust:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants