Release 2.5 #2
Merged
Release 2.5 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with when changing main classes
…o use inheritance, and where I want to just use generics and functions
…e parameterization and cleanup
…o. Recompile to see xlint warnings
… out a couple new features for the survey data grader, and see how that works out
…e generics madness
…match the data set type provided
…ser is a bit of a mess though
…e extractor from grabbing invalid rows
… clean up to see if that helps
…returned null, and that was tried to convert to an int, so that's what caused the error. Fixed now
…t. Hopefully I can sort this out more once I get back
…ere the GPS coords isn't grading properly
…l have some hack-and-slash cleanup to do
… week stuff before continuing though
… See CSV parser.foreachrowin. getHeaderMap is null. Not feeling up to fixing right now.
…s no headers are provided, so I had to specify that the first row is headers. Now I'm having an issue where is says the x and y columns of data sets match 100%, even when they shouldn't.
…verage based on how many matches the ElementMatcherFinds. This meant if it found only one match, someone would get 100% regardless of how many they missed. Now it gives too low a grade, so I'll have to fix that
…ertain it shouldn't. Deal with it later.
…nverters and data parsers
… to reorganize subclasses of AbstractTableParser though, but then I should be done with the data package for this version
…eing added by the Grader. I will want to clean up the DrawingCheckerData's way of handling criteria though
…ate classes for each attribute, as that just adds a lot of clutter. I'm not sure I like storing all this data as a static class, maybe just passing it from page to page a la a form would be better?
… Apparently, I need only include that notation when the class needs to know what type the generic class is parameterized with
…easing everything tomarrow
Done with version 2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time for a new release!