merge from base #10
Merged
merge from base #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…way. - An extension is a field of a Location.
- Previously there was only a method for 'class'.
- Still needs to find indirect subclasses of Exception.
- Instance fields to facilitate definition of new methods. - Using a tuple to return two values. -- Tuple also has the benefit of nice names.
- An error was silently finishing the loop. -- We had to check if the key was present in the map.
- Removing unecessary comments and debug prints.
- Extracting key membership logic in own method. - Changing old 'for's to a more for-each syntax like.
- Forgot a '*', meaning that more than one class modifier would not pattern match.
- Initializing at module level didn't reset the state on future calls.
- Don't know why, but errors occur when don't.
- Assuring test are independent/isolated. - Slower runtime but still fast due to small example case. - I didn't find a DRY way to do it like JUnit's @before -- Tests don't run in declaration order. We can't declare a function first and expect it to work. - It only ran once at test startup, much like @BeforeClass.
- Considering that we might have several class definitions in one
unit(.java file)
-- Before we were returning after the first class definition, ignoring
following definitions.
--- This also produced unwanted behavior to capture a superClassName when
multiple classes were defined within the same unit
- Finding classes with super classes in only one visit.
-- 'Superclass' is actually part of 'NormalClassDeclaration' syntax
- Introducing an AlgebraicDataType to handle class' and superClass' names
-- Replacing the tuple used previously
- Our syntax isn't 100%, so there are multiple classes that can't be parsed
…ration - This is actually a little different implementation from LAMBDAFICATOR
- The transformations are mostly having identation problems.
Great contribution @dvmarcilio ! We will send some pull requests using it. Thanks .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.