Skip to content

[refactor] Separate line number logic from editor view model #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 19, 2024
Merged

[refactor] Separate line number logic from editor view model #46

merged 4 commits into from
Apr 19, 2024

Conversation

@dev-ant
Copy link
Owner

@dev-ant dev-ant commented Apr 19, 2024

📋 Description

  • Seperate Separate line number logic successfully
  • also reduce ui update call

📊 Checklist

  • PR title format well e.g. [feat] Register PR
  • Code has been tested not really
  • Documentation has been updated
  • Removed Any unnecessary code
  • Issue and label registered

📆 Date of Pull Request

April 19th

Close #45

@dev-ant dev-ant added the refactor Suggest improvements or refactoring label Apr 19, 2024
@github-actions
Copy link

github-actions bot commented Apr 19, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit c80b131. ± Comparison against base commit 549a7bb.

@dev-ant dev-ant merged commit 137869f into dev Apr 19, 2024
@dev-ant dev-ant deleted the refactor/#45 branch April 19, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

refactor Suggest improvements or refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Separate line number logic from editor view model

2 participants

@dev-ant