Cfr 007 refactor layer architecture #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the UserService is doing too much things due to spring-boot architecture, I decided to split the repsonsibilities for the UserService being only used for pass informations to several component being passed to the service's controller. This way we make the UserService responsible for only passing the informations to several layer + CREATE EmailSpecification used to verify if the email isn't unique along the datastore + CREATED EmailValidator used to verify that the email passed as parameter is valid + UPDATE the UserService to take the both validator into account + UPDATE the repository to add method for checking email uniqueness
+ ADD method to change the password onto the UserService + CREATE component used for verifying the password + CHANGE the UserService by creating a changePassword method that is then used by the controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the service grows, so many responsibilities go inside it, that makes it inmaintainable on the long run. That's why I decided to make the service an object that will just forward the call of the controller to the specific service.
And thanks to the spring-boot Controller annotation and the construction injection, it makes the code a better candidate for unit test.