Skip to content

Conversation

@hyu-dev
Copy link
Contributor

@hyu-dev hyu-dev commented Oct 19, 2025

CheckBox 컴포넌트, 말씀주신 내용에 따라 아래와 같이 수정했습니다.

  • 내부 상태관리 적용
    • 사용자가 외부에서 checked 옵션을 넣지 않았어도 동작할 수 있도록 적용하기 위함
  • checkIcon 일관된 중앙 정렬을 위한 코드 반영
    • 기존 checkIcon 에 주었던 absolute, transform translate -50% 등 해당 코드가 mac에서는 중앙정렬이 아닌 하단에 붙는 문제가 있어 수정
    • Input 컴포넌트를 감싸는 Box 컴포넌트 대신 label 적용, display flex 및 정렬 반영
    • Input 컴포넌트에 position absolute, z-index 0 (배경처럼 사용)
    • checkIcon 에 position absolute 제거, opacity 1, z-index 1 반영 (input 보다 앞으로 나올 수 있도록)
  • light-dark(var(--primary, #fff), var(--primary, #000)) 형태를 var(--primary, light-dark(#fff, #000)) 으로 변경
    • 값이 더 짧아지는 효과
    • 단, color-mix를 준 경우는 제외
  • styleVars 적용 안된 부분 반영, 불필요한 값 제거
  • check label dark 모드에서 text 기본값 변경
    • devup UI 공식 문서 Components > CheckBox에 dark 모드로 disable 컴포넌트 적용하면 text색상이 안보임

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2025

🦋 Changeset detected

Latest commit: 73b44b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@devup-ui/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...kages/components/src/components/Checkbox/index.tsx 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@owjs3901 owjs3901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changesets to commit

@owjs3901 owjs3901 merged commit ae28981 into dev-five-git:main Oct 26, 2025
2 checks passed
This was referenced Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants