Skip to content

Fix button keyframe #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

Fix button keyframe #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b732651
hotfix button keyframe
belltalion Oct 28, 2025
4dde835
hotfix button keyframe
belltalion Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wicked-sloths-agree.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@devup-ui/components': patch
---

Hotfix button keyframe
21 changes: 12 additions & 9 deletions packages/components/src/components/Button/IconSpinner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
import { Box, keyframes } from '@devup-ui/react'
import { SVGProps } from 'react'

const spin = keyframes({
'0%': {
transform: 'rotateZ(0deg)',
},
'100%': {
transform: 'rotateZ(360deg)',
},
})

interface IconSpinnerProps extends SVGProps<SVGSVGElement> {
type?: 'whole' | 'partial'
}

export function IconSpinner({ type = 'whole', ...props }: IconSpinnerProps) {
/**
* TODO: After fixing the keyframes issue, keyframe must be moved to outside function
*/
const spin = keyframes({
'0%': {
transform: 'rotateZ(0deg)',
},
'100%': {
transform: 'rotateZ(360deg)',
},
})

if (type === 'partial') {
return (
<Box
Expand Down