Skip to content

feat: normalize secret input keys to UPPER_SNAKE_CASE#69

Merged
github-actions[bot] merged 1 commit into
mainfrom
normalize-secret-input-keys
Apr 12, 2026
Merged

feat: normalize secret input keys to UPPER_SNAKE_CASE#69
github-actions[bot] merged 1 commit into
mainfrom
normalize-secret-input-keys

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Summary

Renames all secret input keys in action definitions, test workflows, and documentation from kebab-case to UPPER_SNAKE_CASE, consistent with how secrets are referenced via ${{ secrets.SECRET_NAME }}.

Changes

Action definitions (action.yaml)

APP_PRIVATE_KEY
CODECOV_TOKEN
APP_PRIVATE_KEY
GITHUB_TOKEN
GITHUB_TOKEN
GITHUB_TOKEN

Callers (.github/workflows/)

  • Updated active-release.yaml and all test-*.yaml workflows to use new key names

Documentation

  • Updated all README.md input tables and usage examples
  • Updated CONTRIBUTING.md naming convention guidance to distinguish secret vs non-secret inputs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 12, 2026 20:45
@github-actions github-actions Bot enabled auto-merge (squash) April 12, 2026 20:45
@github-actions github-actions Bot merged commit 82ef4a7 into main Apr 12, 2026
32 checks passed
@github-actions github-actions Bot deleted the normalize-secret-input-keys branch April 12, 2026 20:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes secret-related action input keys across the repository by renaming them from kebab-case to UPPER_SNAKE_CASE, and updates all internal callers and documentation accordingly.

Changes:

  • Renamed secret inputs in multiple action.yaml files (e.g., github-tokenGITHUB_TOKEN, app-private-keyAPP_PRIVATE_KEY, codecov-tokenCODECOV_TOKEN).
  • Updated .github/workflows/* callers (test workflows + release workflow) to pass the new input keys.
  • Updated action READMEs and CONTRIBUTING.md to document the new convention (kebab-case for non-secret inputs, UPPER_SNAKE_CASE for secret inputs).

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
upsert-issue/README.md Updates documented token input name to GITHUB_TOKEN.
upsert-issue/action.yaml Renames token input key and updates inputs.* references.
setup-go-toolchain/README.md Updates documented token input name to GITHUB_TOKEN and usage examples.
setup-go-toolchain/action.yaml Renames token input key and updates step if / env references.
run-dotnet-tests/README.md Renames secret inputs in docs/examples to APP_PRIVATE_KEY, GITHUB_TOKEN, CODECOV_TOKEN.
run-dotnet-tests/action.yaml Renames secret inputs and updates all inputs.* references in steps/conditions.
login-to-ghcr/README.md Updates documented token input name to GITHUB_TOKEN and usage example.
login-to-ghcr/action.yaml Renames token input key and updates inputs.* reference.
create-issues-from-todos/README.md Updates documented app private key input name to APP_PRIVATE_KEY.
create-issues-from-todos/action.yaml Renames app private key input key and updates inputs.* reference.
CONTRIBUTING.md Documents the new split convention: kebab-case for non-secret vs UPPER_SNAKE_CASE for secret inputs.
approve-pr/README.md Updates documented app private key input name to APP_PRIVATE_KEY.
approve-pr/action.yaml Renames app private key input key and updates inputs.* reference.
.github/workflows/test-upsert-issue.yaml Updates caller to pass GITHUB_TOKEN.
.github/workflows/test-setup-go-toolchain.yaml Updates caller to pass GITHUB_TOKEN.
.github/workflows/test-run-dotnet-tests.yaml Updates caller to pass APP_PRIVATE_KEY and GITHUB_TOKEN.
.github/workflows/test-login-to-ghcr.yaml Updates caller to pass GITHUB_TOKEN.
.github/workflows/test-create-issues-from-todos.yaml Updates caller to pass APP_PRIVATE_KEY.
.github/workflows/test-approve-pr.yaml Updates caller to pass APP_PRIVATE_KEY.
.github/workflows/active-release.yaml Updates reusable workflow secret key to APP_PRIVATE_KEY.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

if: inputs.CODECOV_TOKEN != ''
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
with:
files: ${{ steps.get_coverage_files.outputs.COVERAGE_FILES }}

Copilot AI Apr 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, get_coverage_files is skipped (only get_coverage_files_windows runs), but the Codecov upload still references steps.get_coverage_files.outputs.COVERAGE_FILES. This will be empty/undefined on Windows and can cause missing uploads or failures. Consider unifying both steps under a single id, or selecting the correct output based on matrix.os (e.g., prefer the Windows step output when running on Windows).

Suggested change
files: ${{ steps.get_coverage_files.outputs.COVERAGE_FILES }}
files: ${{ matrix.os == 'windows-latest' && steps.get_coverage_files_windows.outputs.COVERAGE_FILES || steps.get_coverage_files.outputs.COVERAGE_FILES }}

Copilot uses AI. Check for mistakes.
@botantler-1

botantler-1 Bot commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@botantler-1 botantler-1 Bot added the released label Apr 12, 2026
@botantler-1 botantler-1 Bot mentioned this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants