Skip to content

fix: add GITHUB_TOKEN and GITHUB_ACTOR to workflow reconcile steps#1345

Merged
botantler[bot] merged 1 commit intomainfrom
devantler/fix-workflow-reconcile-github-token
Apr 11, 2026
Merged

fix: add GITHUB_TOKEN and GITHUB_ACTOR to workflow reconcile steps#1345
botantler[bot] merged 1 commit intomainfrom
devantler/fix-workflow-reconcile-github-token

Conversation

@devantler
Copy link
Copy Markdown
Contributor

Summary

Adds missing GITHUB_ACTOR and GITHUB_TOKEN environment variables to the workload reconcile steps in both cd.yaml and ci.yaml (deploy-dev job). KSail needs these to resolve the GHCR registry URL from the config.

Changes

  • .github/workflows/cd.yaml — Added GITHUB_ACTOR and GITHUB_TOKEN to the "🔁 Trigger Flux reconciliation" step env block
  • .github/workflows/ci.yaml — Added GITHUB_ACTOR and GITHUB_TOKEN to the "🔁 Trigger Flux reconciliation" step env block in the deploy-dev job

Fixes #1343

The workload reconcile steps in cd.yaml and ci.yaml were missing
GITHUB_ACTOR and GITHUB_TOKEN environment variables. KSail needs
these to resolve the GHCR registry URL from the config.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 11, 2026 15:14
@botantler botantler Bot enabled auto-merge April 11, 2026 15:14
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to 🚀 In Finalization in 🌊 Project Board Apr 11, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing GitHub Actions auth environment variables to KSail workload reconcile steps so KSail can expand the GHCR registry URL from ksail.*.yaml during reconciliation (aligning reconcile with the existing push steps).

Changes:

  • Add GITHUB_ACTOR and GITHUB_TOKEN to the workload reconcile step in .github/workflows/cd.yaml.
  • Add GITHUB_ACTOR and GITHUB_TOKEN to the workload reconcile step in .github/workflows/ci.yaml (deploy-dev job).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci.yaml Ensures deploy-dev reconcile step has the same GHCR-related env vars as the create/update and push steps.
.github/workflows/cd.yaml Ensures prod reconcile step can resolve the GHCR registry URL via env var expansion during ksail ... workload reconcile.

@botantler botantler Bot added this pull request to the merge queue Apr 11, 2026
Merged via the queue into main with commit 6355d8d Apr 11, 2026
12 checks passed
@botantler botantler Bot deleted the devantler/fix-workflow-reconcile-github-token branch April 11, 2026 15:28
@github-project-automation github-project-automation Bot moved this from 🚀 In Finalization to ✅ Done in 🌊 Project Board Apr 11, 2026
@botantler
Copy link
Copy Markdown
Contributor

botantler Bot commented Apr 11, 2026

🎉 This PR is included in version 2.33.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[bug]: CD and CI workflows missing GITHUB_TOKEN in workload reconcile step

2 participants