fix: add GITHUB_TOKEN and GITHUB_ACTOR to workflow reconcile steps#1345
Merged
botantler[bot] merged 1 commit intomainfrom Apr 11, 2026
Merged
Conversation
The workload reconcile steps in cd.yaml and ci.yaml were missing GITHUB_ACTOR and GITHUB_TOKEN environment variables. KSail needs these to resolve the GHCR registry URL from the config. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing GitHub Actions auth environment variables to KSail workload reconcile steps so KSail can expand the GHCR registry URL from ksail.*.yaml during reconciliation (aligning reconcile with the existing push steps).
Changes:
- Add
GITHUB_ACTORandGITHUB_TOKENto theworkload reconcilestep in.github/workflows/cd.yaml. - Add
GITHUB_ACTORandGITHUB_TOKENto theworkload reconcilestep in.github/workflows/ci.yaml(deploy-dev job).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yaml | Ensures deploy-dev reconcile step has the same GHCR-related env vars as the create/update and push steps. |
| .github/workflows/cd.yaml | Ensures prod reconcile step can resolve the GHCR registry URL via env var expansion during ksail ... workload reconcile. |
Contributor
|
🎉 This PR is included in version 2.33.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing
GITHUB_ACTORandGITHUB_TOKENenvironment variables to theworkload reconcilesteps in bothcd.yamlandci.yaml(deploy-dev job). KSail needs these to resolve the GHCR registry URL from the config.Changes
.github/workflows/cd.yaml— AddedGITHUB_ACTORandGITHUB_TOKENto the "🔁 Trigger Flux reconciliation" step env block.github/workflows/ci.yaml— AddedGITHUB_ACTORandGITHUB_TOKENto the "🔁 Trigger Flux reconciliation" step env block in the deploy-dev jobFixes #1343