Skip to content

Use "dependsOn" for hard Go dependency #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2023
Merged

Use "dependsOn" for hard Go dependency #5

merged 2 commits into from
Sep 5, 2023

Conversation

@jcbhmr
Copy link
Member

@jcbhmr jcbhmr commented Aug 31, 2023 •
edited
Loading

You must have Go already installed on your machine in order to install TinyGo. We recommend Go v1.18 or above.

— https://tinygo.org/getting-started/install/linux/

there's this cool thing: https://github.com/devcontainers/spec/blob/main/proposals/feature-dependencies.md

and its in the main spec: devcontainers/spec#292

and its in the reference cli: devcontainers/cli#530

this pr would:

  • change customizations.vscode.features to .dependsOn
  • remove the installsAfter: rust, cargo_binstall

@jcbhmr jcbhmr requested a review from lee-orr August 31, 2023 21:10
@jcbhmr jcbhmr merged commit 1e72542 into main Sep 5, 2023
@jcbhmr jcbhmr deleted the jcbhmr-patch-1 branch September 5, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lee-orr lee-orr lee-orr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcbhmr @lee-orr