-
Notifications
You must be signed in to change notification settings - Fork 341
Closed
Labels
candidateIssue identified as probable candidate for fixing in the next releaseIssue identified as probable candidate for fixing in the next release
Milestone
Description
After updating to docker v29.0.0 (https://github.com/moby/moby/releases/tag/docker-v29.0.0), my devcontainers that use docker compose files started to hang when starting up.
Reproducible Example:
$ cat docker-compose.yml
services:
container:
container_name: container
image: debian
tty: true
stdin_open: true
$ cat .devcontainer/devcontainer.json
{
"workspaceFolder": "${localWorkspaceFolder}",
"dockerComposeFile": ["${localWorkspaceFolder}/docker-compose.yml"],
"service": "container"
}
$ devcontainer up --remove-existing-container --workspace-folder .
...
[+] Running 1/1
✔ Container container Started 0.2s
^C
It seems like this is because of the following deprecation:
GET /events no longer includes the deprecated status, id, and from fields. These fields were removed in API v1.22, but still included in the response. These fields are now omitted when using API v1.52 or later.
Manually patching line 182 of src/spec-node/utils.ts to be (info.status || info.Status || info.Action) === 'start' seemed to fix the issue, but not sure if this might have other unintended side effects.
Joseluis-esaverohitshriwas, staffanf and yvanitou-amicalcawolfdev and mapibyronc-synthrics
Metadata
Metadata
Assignees
Labels
candidateIssue identified as probable candidate for fixing in the next releaseIssue identified as probable candidate for fixing in the next release