Skip to content

Conversation

@samruddhikhandale
Copy link
Member

https://github.com/devcontainers/devcontainers.github.io/actions/runs/4196382156/jobs/7277279916#step:7:69
Looks like the yaml parser doesn't allow @ as the first letter for any token, removing that to fix the action failures.

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner February 16, 2023 17:20
ociReference: ghcr.io/swift-server/swift-devcontainer-template
- name: Android SDK Tools and Apt packages
maintainer: @akhildevelops
maintainer: akhildevelops
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akhildevelops Apologies for updating the maintainer section for your added entry. However, looks like @ as the first letter it is not acceptable by the parser and we are having build failures.

https://github.com/devcontainers/devcontainers.github.io/actions/runs/4196382156/jobs/7277279916#step:7:69

Feel free to update your entry if needed, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other maintainer names omit the @, so for consistency sake this is good. I think we could also quote the value, but if it's all the same to @akhildevelops - looks good

@samruddhikhandale samruddhikhandale merged commit 0191299 into gh-pages Feb 16, 2023
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/nit branch February 16, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants