Added guide for GitLab CI #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tagging @bamurtaugh for review |
Member
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
This looks great, thank you! ✨
Left some thoughts/comments :)
Member
|
Thanks so much for opening this @raginjason, this looks like a great guide! And thanks @samruddhikhandale for the quick review ✨ - I agree with the suggestions she mentions. |
joshspicer
reviewed
Feb 27, 2023
| }, | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/aws-cli:1": {}, | ||
| "ghcr.io/devcontainers-contrib/features/aws-cdk:2": {} |
Member
There was a problem hiding this comment.
To avoid confusion for folks, it would be nice to point out that devcontainers-contrib is community-maintained (issues on our repos likely wouldn't help get issues in these Features fixed as fast)
Contributor
Author
There was a problem hiding this comment.
@joshspicer I've added a note in the paragraph above, does this satisfy your concern? (see 02b35db)
Contributor
Author
|
@microsoft-github-policy-service agree company="DataScan" |
raginjason
force-pushed
the
working-with-gitlab-ci
branch
from
e4842bd to
7e769c3
Compare
raginjason
force-pushed
the
working-with-gitlab-ci
branch
from
7e769c3 to
02b35db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This guide came out of a discussion in devcontainers/ci#205. While GitHub has a devcontainer action, nothing like this exists for GitLab CI. This caused a bit of a gap in documentation on how to get advanced devcontainer functionality into GitLab CI. This PR is designed to close that gap.