proposed feature for .net aspire

[danmoseley]

Prior art published from their own repos --
".NET Aspire" https://github.com/NikiforovAll/devcontainer-features
".NET Aspire Daily Builds" https://github.com/ElanHasson/devcontainer-features
Thank you @NikiforovAll and @ElanHasson for publishing these!

These happen to be at the top of the list:

Both of these use the old way to install .NET Aspire, based on "dotnet workload". This only works with Aspire 8.0. From Aspire 9.0 onwards, this is no longer relevant. Anyone using Aspire today will likely want 9.0 or later.

I considered offering PR's to update each of them, but it seems to me that it would be better to have a single devcontainer feature for .NET Aspire which handled both scenarios plus arbitrary versions (>=9.0). This is that.

Merging this would require that the existing features be unpublished when this was merged, or this uses a different name. @NikiforovAll and @ElanHasson what would you think of replacing yours with a combined one?

cc @joperezr @davidfowl

When merged it could replace this line in the Aspire repo

[danmoseley]

cc @joshspicer as he wrote the dotnet one (thanks)

[ElanHasson]

Hey @danmoseley!

I'm cool with that, hopefully it'll be an official feature 😎

Let me know what you'd like me to do and when.

[danmoseley]

tests pass locally; ready for review.

[danmoseley]

@joshspicer could you possibly have a look? and enable workflows if possible.

[bamurtaugh]

Thank you @danmoseley @davidfowl for the contribution!

@chrmarti @eljog if you get a moment, could you provide a review? Thanks so much!

[danmoseley]

@NikiforovAll when we're ready to click merge on this, would you be OK un-publishing ".NET Aspire" from https://github.com/NikiforovAll/devcontainer-features ? this is a superset of yours, and saves you maintaining. Appreciate you creating it originally though.

This one will then take over the name.

[danmoseley]

@bamurtaugh could you please click to enable workflows?

[NikiforovAll]

@NikiforovAll when we're ready to click merge on this, would you be OK un-publishing ".NET Aspire" from https://github.com/NikiforovAll/devcontainer-features ? this is a superset of yours, and saves you maintaining. Appreciate you creating it originally though.

This one will then take over the name.

How do I unpublish it? Could you please assist?

[danmoseley]

How do I unpublish it? Could you please assist?

Consulted @bamurtaugh and what we need is for you @NikiforovAll and for @ElanHasson to go ahead and delete from your repos the .NET Aspire related DC features.

I can't just remove you from https://github.com/devcontainers/devcontainers.github.io/blob/gh-pages/_data/collection-index.yml because you have other DC features that would be lost and I don't want that.

Once you've deleted them, I can hopefully merge this; no idea how it would resolve naming conflicts otherwise.

Thanks both of you!!

[ElanHasson]

Sure. I'll take care of it.

Just delete from the git repo, right? I want to leave the oci image there in case someone depends on it.

[NikiforovAll]

@danmoseley I've removed aspire feature from my repo - https://github.com/NikiforovAll/devcontainer-features

[ElanHasson]

@danmoseley done!

[danmoseley]

OK what remains here is code review and confirmation of the answer to

Just delete from the git repo, right? I want to leave the oci image there in case someone depends on it.

[bamurtaugh]

@Kaniska244 it'd be great to get your support here, thanks so much!

[danmoseley]

We need this merged as the other ones are now gone.

[Kaniska244]

Hi @danmoseley ,

Thank you for the PR. Would you kindly update/ clean up the test scripts. I see some empty tests are added in the sources. Please add the relevant checks in those scripts. Kindly let me know in case of any concern.

With Regards,
Kaniska Sengupta

[danmoseley]

Thank you for the PR. Would you kindly update/ clean up the test scripts. I see some empty tests are added in the sources.

@Kaniska244 my understanding of the test infrastructure is that every scenario in scenarios.json needs a test file, even if empty. Is that not the case?

[danmoseley]

Per discussion offline, moving to our own repo. I will reopen either in dotnet/aspire or a specific repo shortly.

[danmoseley]

replaced in dotnet/aspire-devcontainer-feature#1

[danmoseley]

Sure. I'll take care of it.

Just delete from the git repo, right? I want to leave the oci image there in case someone depends on it.

@NikiforovAll @ElanHasson I realized that you DO need to do more than delete from the repo -- their indexer doesn't go look at repos, I guess, which should have been obvious to me: you have to kick your publish github action. If you wouldn't mind, please go to these respectively and hit Run Workflow please?

https://github.com/NikiforovAll/devcontainer-features/actions/workflows/release.yaml
https://github.com/ElanHasson/devcontainer-features/actions/workflows/release.yaml

I asked @bamurtaugh and she said that if you do this,

The features should still be downloadable because their OCI artifacts are still there, they're only gone from the source repository

[danmoseley]

Hopefully once you've done that, and the indexer runs (which seems to be 0900 UTC) we are all set.

[ElanHasson]

@danmoseley done!

[NikiforovAll]

I encountered https://github.com/NikiforovAll/devcontainer-features/actions/runs/13604401692/job/38034179886

Do you have any ideas on how to fix it?

[danmoseley]

@NikiforovAll it's updating your README's to match the code. It created a branch, it just wants you to create a PR and merge it for
https://github.com/NikiforovAll/devcontainer-features/compare/automated-documentation-update-13604401692?expand=1

My guess is once the docs are up to date in the repo, this action will run clean.

[danmoseley]

something worked?

[danmoseley]

thanks everyone who helped! Please share any feedback at dotnet/aspire-devcontainer-feature