Skip to content

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Nov 21, 2025

Run cargo clippy, and cargo fmt with import sorting, specifically:

cargo clippy --all-targets --all-features
cargo clippy --all-targets --all-features --manifest-path python/Cargo.toml

cargo fmt --all --check -- --config imports_granularity=Module,group_imports=StdExternalCrate
cargo fmt --all --check --manifest-path python/Cargo.toml -- --config imports_granularity=Module,group_imports=StdExternalCrate

Fixes #107.

Run cargo clippy, and cargo fmt with import sorting.
@weiji14 weiji14 self-assigned this Nov 21, 2025
@weiji14 weiji14 marked this pull request as ready for review November 21, 2025 21:42
@weiji14 weiji14 changed the title CI: Add clippy and fmt lints ci: Add clippy and fmt lints Nov 21, 2025
@weiji14
Copy link
Member Author

weiji14 commented Nov 21, 2025

Just realized clippy and fmt are already ran here:

- name: Cargo fmt
run: cargo fmt --all -- --check
- name: "clippy --all"
run: cargo clippy --all --all-features --tests -- -D warnings

Personally prefer separate lint/test workflows, so will push some commits for that, but lemme know if I should revert to a single Lint + Test workflow.

@weiji14
Copy link
Member Author

weiji14 commented Nov 21, 2025

Will need to update the required tests before merging.

@kylebarron kylebarron enabled auto-merge (squash) November 22, 2025 00:58
Copy link
Member

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kylebarron kylebarron merged commit bdfda31 into main Nov 22, 2025
8 checks passed
@kylebarron kylebarron deleted the lint/clippy_and_fmt branch November 22, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce import ordering in CI

3 participants