feat: build abi3 wheels #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
issues/93-wheels
branch
from
8423370 to
73c37c3
Compare
gadomski
commented
Oct 31, 2025
|
|
||
| #[cfg(test)] | ||
| use {assert_json_diff as _, rstest as _}; | ||
| use {::duckdb as _, assert_json_diff as _, rstest as _}; |
Collaborator
Author
There was a problem hiding this comment.
This import became required in rustc v1.91 ... we use the crate in an integration test, but I guess v1.91 doesn't pick that up?
gadomski
commented
Oct 31, 2025
|
|
||
| [tool.uv] | ||
| dev-dependencies = [ | ||
| [dependency-groups] |
Collaborator
Author
There was a problem hiding this comment.
This was throwing a warning.
vincentsarago
approved these changes
Oct 31, 2025
kylebarron
reviewed
Oct 31, 2025
| [project] | ||
| name = "cql2" | ||
| requires-python = ">=3.9" | ||
| requires-python = ">=3.11" |
Member
There was a problem hiding this comment.
Are you ok skipping 3.10 as well?
kylebarron
reviewed
Oct 31, 2025
| with: | ||
| target: ${{ matrix.platform.target }} | ||
| args: --release --out dist --find-interpreter | ||
| args: --release --out dist -i 3.11 -F pyo3/abi3-py311 |
Member
There was a problem hiding this comment.
IMO it's slightly nicer to put the feature flag into Cargo.toml
Is there a feature in py3.11 that you need? Or you wanted to bump past 3.10 anyways?
Member
|
Sorry for being slow 😛 |
Collaborator
Author
|
Nah you're good, let's fix it up. I just copy-pastad from rustac-py, not thinking that 3.10 would work w/ ABI. I'll open a follow-on. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #93, but we need to do a release before that issue can be considered fixed. Includes some sidecar cleanups, including testing against a Python matrix.
Other notes:
The wheel from the Python build looks good on my mac: