Fix issues discovered in initial deployment. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkinsspatial
force-pushed
the
fix/deployment_issues
branch
from
7a5efce to
e032113
Compare
sharkinsspatial
force-pushed
the
fix/deployment_issues
branch
from
e032113 to
95b0b83
Compare
Member
|
If it's okay with you, I'm going to avoid reviewing this and we can instead discuss & merge in these changes in #10 |
This was referenced Jan 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several small logic errors and an unsolved issue involving Lambda role assumption were discovered during the initial attempt at deploying the
cdk-pgstacconstruct via https://github.com/developmentseed/aws-asdi-pgstac. The included fix for using a broad role for public buckets is temporary and we'll need to diagnose the issue we are seeing withassume_rolegoing forward.